Allow custom viewport implementations #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psaavedra
force-pushed
the
psaavedra/custom_viewport
branch
from
827fc79 to
c0774f6
Compare
aperezdc
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
I like the direction of this patch, and I have a couple of minor comments. Please fix the missing voids in function argument lists and this can be merged.
(Nice to see one more step in the right direction to allow programs that use the cogcore library to decide themselves how to display the web views, I feel like we are getting close! 👏🏼)
Optionally, platform plug-in implementations can provide their own viewport class by overriding the CogPlatform.get_viewport_type method.
psaavedra
force-pushed
the
psaavedra/custom_viewport
branch
from
c0774f6 to
7d61386
Compare
psaavedra
force-pushed
the
psaavedra/custom_viewport
branch
from
7d61386 to
0dfafb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excerpt: This PR allows platform implementations to provide their own viewport class. The WL Viewport class will handle the things associated with the window geometry instead of this being handled directly from the platform object.
motivation Optionally, platform plug-in implementations can provide their own viewport class by overriding the CogPlatform.get_viewport_type method. The
CogWlWindowis moved inside of theCogWlViewport. The Window struct contains the information related to the geometry of the surface where the webview has to be painted. This information naturally belongs to the Viewport and not directly to the platform. With this change we correctly encapsulate the Window information in the right place.