Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant refresh token if is configured to client #89

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

lionick
Copy link
Contributor

@lionick lionick commented Dec 12, 2023

When a client has been configured with refresh_token as part of its grant_types_supported
then, we should grant it, even if refresh_token is not at global configuration.

CC: @c00kiemon5ter @NicolasLiampotis

@c00kiemon5ter
Copy link
Member

c00kiemon5ter commented Dec 12, 2023

This work should be done against the main branch.
We are in the process of removing the develop branch.

@lionick lionick changed the base branch from develop to main December 13, 2023 07:48
@lionick
Copy link
Contributor Author

lionick commented Dec 13, 2023

I have changed the base branch to main.

Copy link
Member

@c00kiemon5ter c00kiemon5ter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that client-specific settings are respected and override the global AS settings - in this case for the supported grant types.

@rohe rohe merged commit 774ddc4 into IdentityPython:main Dec 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants