Identity Assurance support has been out in the cold. Time to bring it in again. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to follow the last version of the spec.
Added a signing algorithm that is supported by cryptojwt. Had two copies of the same functions (get_signing_algs,get_encryption_algs,get_encryption_encs) in different places reduced that to one.
…ntext (if one exists). This is useful when it comes to keyjars. Store the original signed or encrypted jwt as part of the parsed and verified response.
Allow for checking context instance when looking for attributes. Look for client authn methods in endpoint as well as in context.
… by a server. 'allowed_methods' are then ones that can be used by a specific endpoint
Signed-off-by: Kostis Triantafyllakis <[email protected]>
Signed-off-by: Kostis Triantafyllakis <[email protected]>
Signed-off-by: Kostis Triantafyllakis <[email protected]>
Added a signing algorithm that is supported by cryptojwt. Had two copies of the same functions (get_signing_algs,get_encryption_algs,get_encryption_encs) in different places reduced that to one.
rohe
changed the title
peppelinux
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Approved
for the next PR I kidnly suggest to not have additional features or bufix commits mixed with linting commit for sake of readability
I know that would repreent a bane for the developer who made the PR but without this way to do the bane would be for the reviewers :-)
thank you @rohe for this valuable PR that makes a new important release of idpy-oidc
PS = I didn't had time to do accurate functional tests, I look forward to @ctriant for any additional check according to its implementation test platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identity Assurance is important in connection with openid4vci/openid4vp.