Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump load #101

Merged
merged 8 commits into from
May 24, 2024
Merged

Dump load #101

merged 8 commits into from
May 24, 2024

Conversation

rohe
Copy link
Contributor

@rohe rohe commented Apr 27, 2024

The dump/load methods used for persistence storage of state was not working well in the general case.
This PR fixes that

@rohe rohe requested a review from peppelinux April 27, 2024 09:49
@rohe rohe requested a review from ctriant April 27, 2024 10:02
@rohe rohe requested review from lionick and removed request for ctriant May 9, 2024 17:47
@rohe
Copy link
Contributor Author

rohe commented May 14, 2024

@lionick and @peppelinux I really would like to have your reviews.

Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have time to test it with satosa-oidcop but it seems formally good, I just have added a quick suggestion to reduce the hadoken code

src/idpyoidc/impexp.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lionick lionick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running my tests at oidc frontend, I can confirm that everything works as expected.

@rohe
Copy link
Contributor Author

rohe commented May 24, 2024

Completely baffled. Checks fail on a test that is not part of the package ?!

@rohe rohe merged commit 56a4799 into main May 24, 2024
1 of 5 checks passed
@rohe rohe deleted the dump_load branch May 24, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants