Add PAR support #421
Merged
Add PAR support #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephdecock
commented
Apr 2, 2024
josephdecock
commented
Apr 2, 2024
|
Consider enabling PAR by default (when present in disco), with the option being to opt out. And mention that we've done this in the log. Edit: resolved |
If PAR fails, we now surface that failure in the same way that other response types do.
- Remove defunct ConsoleClient - Add a manual mode console client
Closed
We don't care about strong naming in general, and we definitely don't care in a test project
brockallen
reviewed
Apr 3, 2024
brockallen
reviewed
Apr 5, 2024
brockallen
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.