Add Rustls support #129
Closed
Add Rustls support #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldesh
reviewed
Jul 20, 2022
.circleci/config.yml
Outdated
| name: More unit testing | ||
| name: Unit testing with ssl-rustls feature | ||
| command: | | ||
| RUST_BACKTRACE=1 cargo test -j 8 --verbose --features ssl |
There was a problem hiding this comment.
Is your intention to specify the ssl-rustls option?
eldesh
reviewed
Jul 20, 2022
| docker load -i test-signal | ||
| RUST_BACKTRACE=1 cargo test --verbose --features ssl -- --ignored | ||
| - run: | ||
| name: More unit testing with ssl-rustls feature | ||
| command: | | ||
| docker load -i test-iostream | ||
| docker load -i test-signal |
There was a problem hiding this comment.
Same above (ssl-rustls?).
And in this point, test-iostrem and test-signal are loaded already at More unit testing with ssl feature.
|
(Are you talking about the #128 ?) |
|
Rustls does not seem to support connecting to IP address. However, docker uses IP address. Thus we cannot use Rustls for now. See also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
#812#128 . This patch bumps MSRV to 1.56.0 because rustls requires it.