Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidatorChain should only validate #26

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ValidatorChain should only validate #26

wants to merge 2 commits into from

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Mar 13, 2023 •
edited
Loading

  • The name ValidatedResult isn't set in stone
  • The entire change isn't war-deciding, if we don't want to hush this, we don't need to

@nilmerg
ValidatorChain: Rename isValid() to validate()
cfaf051 
A chain can't be valid IMHO, a value can and that's
what's passed anyway. So let's call it `validate`.

Also allows it to return a different result and
might solve the *message* problem in the future
even more nicely.
@nilmerg
Remove clearMessages() call from all validators
ba0e5c8
@nilmerg nilmerg requested a review from lippserd March 13, 2023 17:07
@nilmerg nilmerg self-assigned this Mar 13, 2023
@cla-bot cla-bot bot added the cla/signed label Mar 13, 2023
nilmerg added a commit to Icinga/ipl-html that referenced this pull request Mar 13, 2023
@nilmerg
BaseFormElement: Respect recent ValidatorChain changes
8f0288b 
This is the only change dependent upon: Icinga/ipl-validator#26
@nilmerg nilmerg marked this pull request as draft March 15, 2023 11:38
@nilmerg nilmerg removed the request for review from lippserd March 15, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nilmerg nilmerg

Labels
cla/signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nilmerg