Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReportForm: Check whether the report name is unique #243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sukhwinder33445
Copy link
Contributor

fixes #218

@sukhwinder33445 sukhwinder33445 added the bug Something isn't working label Jul 22, 2024
@sukhwinder33445 sukhwinder33445 self-assigned this Jul 22, 2024
@cla-bot cla-bot bot added the cla/signed label Jul 22, 2024
Comment on lines 122 to 124
if ($value === null) {
return true;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary. As the field is required, the value is never null.

The form now requires a database instance (RetryConnection), which should be specified as a constructor parameter in order to keep the form dependency-free.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide better error message when attempting to create a duplicate report
2 participants