Pdfexport: Generate PDF before modifying response headers

Icinga · Mar 15, 2024 · 5f08ecb · 5f08ecb
1 parent 9f551aa
commit 5f08ecb
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/library/Pdfexport/ProvidedHook/Pdfexport.php b/library/Pdfexport/ProvidedHook/Pdfexport.php
@@ -132,12 +132,15 @@ public function streamPdfFromHtml($html, $filename)
     {
         $filename = basename($filename, '.pdf') . '.pdf';
 
+        // Generate the PDF before changing the response headers to properly handle and display errors in the UI.
+        $pdf = $this->htmlToPdf($html);
+
         /** @var Web $app */
         $app = Icinga::app();
         $app->getResponse()
             ->setHeader('Content-Type', 'application/pdf', true)
             ->setHeader('Content-Disposition', "inline; filename=\"$filename\"", true)
-            ->setBody($this->htmlToPdf($html))
+            ->setBody($pdf)
             ->sendResponse();
 
         exit;