-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: Add dependency additions #795
base: main
Are you sure you want to change the base?
Conversation
CREATE TABLE `redundancy_group_state` ( | ||
`id` binary(20) NOT NULL, | ||
`redundancy_group_id` binary(20) NOT NULL, | ||
`failed` enum('n', 'y') NOT NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The redundancy_group_state
table is missing last_state_change
column, to track how long since the redundancy group has failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that now it's there twice. Please refer to my other comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems I mixed things up here a bit. dependencies.sql
was the initial script and seemingly intended as full upgrade whereas the other files, 2 and 3, are partial upgrades. Though changes made in 3 didn't made it into the full upgrade. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my testing, I have added the environment ID as environment_id BINARY(20) NOT NULL
to most tables.
alter table redundancy_group_state | ||
add last_state_change bigint unsigned not null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`last_state_change` bigint unsigned NOT NULL, |
Unless I am missing something, it is already there.
CREATE TABLE `redundancy_group_state` ( | ||
`id` binary(20) NOT NULL, | ||
`redundancy_group_id` binary(20) NOT NULL, | ||
`failed` enum('n', 'y') NOT NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that now it's there twice. Please refer to my other comment.
As discussed in #347.
Todo: