Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump base image version #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump base image version #116

wants to merge 2 commits into from

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Oct 26, 2023

Omitting virtual php8.2-json, that extension is always there since PHP 8.

DbCommand now supports PHP 8.2 by not creating dynamic properties.

fixes #128

@Al2Klimov Al2Klimov self-assigned this Oct 26, 2023
@cla-bot cla-bot bot added the cla/signed label Oct 26, 2023
@Al2Klimov Al2Klimov force-pushed the debian12 branch 3 times, most recently from 23aa16c to db8963c Compare October 26, 2023 11:38
@Al2Klimov Al2Klimov marked this pull request as ready for review October 26, 2023 11:41
@Al2Klimov Al2Klimov removed their assignment Oct 26, 2023
@Al2Klimov
Copy link
Member Author

Tested with https://github.com/Al2Klimov/twintowers .

It's for you to decide whether this makes sense for 2.12.1 or not.

@Al2Klimov
Copy link
Member Author

⚠️

If we merge this, you'll have to pin this GHA to a previous commit in upstream support branches not supporting PHP 8.2! (I can do this for you.)

@Al2Klimov
Copy link
Member Author

Alternative

Wait for all IW2 versions not supporting PHP 8.2 to EOL.

@julianbrost
Copy link
Contributor

Yet another alternative: make a @v2 version when doing incompatible changes.

@Al2Klimov
Copy link
Member Author

But then we'd have to maintain multiple branches. My alternative involves less maintenance and it's realistic because Debian 11 will be maintained until Jul 2026. I don't know the exact IW2 release schedule, but idk why we shouldn't see at least a v2.13 by then. Also, why to force all image users to support PHP 8.2 right now? I'd say let's wait 1y+ before bumping the base images. CC @nicolasberens

@Al2Klimov Al2Klimov mentioned this pull request Jul 10, 2024
@Al2Klimov
Copy link
Member Author

Al2Klimov commented Sep 26, 2024

Fact-check

This is false

#116 (comment)

⚠️

If we merge this, you'll have to pin this GHA to a previous commit in upstream support branches not supporting PHP 8.2! (I can do this for you.)

#116 (comment)

Alternative

Wait for all IW2 versions not supporting PHP 8.2 to EOL.

#116 (comment)

But then we'd have to maintain multiple branches. My alternative involves less maintenance and it's realistic because Debian 11 will be maintained until Jul 2026. I don't know the exact IW2 release schedule, but idk why we shouldn't see at least a v2.13 by then. Also, why to force all image users to support PHP 8.2 right now? I'd say let's wait 1y+ before bumping the base images. CC @nicolasberens

This is true

  • Fedora 39 already has PHP 8.2
  • If(!) we make a minor Y of major X, we'll build it for all distros
  • Hence, v2.X.Y will have to support (Fedora 39 and) PHP 8.2 for its release
  • Hence, we could merge this already without anything special

Omitting virtual php8.2-json, that extension is always there since PHP 8.
by not creating dynamic properties.
@Al2Klimov
Copy link
Member Author

@lippserd I've re-built and pushed :2.12.1, :2.12, etc. with this branch, so that we have PHP 8.2 for K8s. So this PR should be merged before a v2.12.2, not to loose PHP 8.2. 😅

@Al2Klimov
Copy link
Member Author

@lippserd Not only it already confuses people (1) that :latest already has PHP 8 while :main doesn't, the latter surely breaks K8s-web in :main, our "snapshot images". 🙈 Two more reasons to merge this. 😅

  1. Docker Image is updates to Debian12 PHP 8.2 #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Image is updates to Debian12 PHP 8.2
3 participants