[FEATURE] gray badge #125
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <?php | ||
|
|
||
| namespace IchHabRecht\ContentDefender\ViewHelpers; | ||
|
|
||
| use TYPO3\CMS\Core\Information\Typo3Version; | ||
| use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface; | ||
| use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper; | ||
| use TYPO3Fluid\Fluid\Core\ViewHelper\Traits\CompileWithRenderStatic; | ||
|
|
||
| class GetVersionViewHelper extends AbstractViewHelper | ||
| { | ||
| use CompileWithRenderStatic; | ||
|
|
||
| public function initializeArguments() | ||
| { | ||
| parent::initializeArguments(); | ||
| } | ||
|
|
||
| public static function renderStatic( | ||
| array $arguments, | ||
| \Closure $renderChildrenClosure, | ||
| RenderingContextInterface $renderingContext | ||
| ) { | ||
| return (new Typo3Version())->getMajorVersion(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
|
|
||
| templates.typo3/cms-backend.100 = ichhabrecht/content-defender:Resources/Private/Backend/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| module.tx_contentdefender { | ||
| view { | ||
| # cat=plugin.tx_contentdefender/file; type=string; label=Path to template root | ||
| templateRootPath = EXT:content_defender/Resources/Private/Backend/Templates/ | ||
| # cat=plugin.tx_contentdefender/file; type=string; label=Path to template partials | ||
| partialRootPath = EXT:content_defender/Resources/Private/Backend/Partials/ | ||
| # cat=plugin.tx_contentdefender/file; type=string; label=Path to template layouts | ||
| layoutRootPath = EXT:content_defender/Resources/Private/Backend/Layouts/ | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| <html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" | ||
| xmlns:cd="http://typo3.org/ns/IchHabRecht/ContentDefender/ViewHelpers" | ||
| data-namespace-typo3-fluid="true"> | ||
|
|
||
| <f:be.pageRenderer includeCssFiles="{0: 'EXT:content_defender/Resources/Public/Css/backend.css'}" /> | ||
|
|
||
| <f:if condition="{cd:getVersion()} == 12"> | ||
| <f:be.pageRenderer includeCssFiles="{1: 'EXT:content_defender/Resources/Public/Css/backend_v12.css'}" /> | ||
| </f:if> | ||
|
|
||
|
|
||
| <cd:extendPartial> | ||
| <f:alias map="{maxitems: '{cd:maxitems(column: column)}'}"> | ||
|
|
||
| <f:variable name="length" value="1"/> | ||
|
|
||
| <f:if condition="{maxitems} > 9"> | ||
| <f:variable name="length" value="2"/> | ||
| </f:if> | ||
|
|
||
| <f:if condition="{maxitems} > 99"> | ||
| <f:variable name="length" value="3"/> | ||
| </f:if> | ||
|
|
||
| <div class="t3-cd-badge-container t3-cd-badge-container-length-{length}" data-maxitems="{maxitems}"> | ||
| <f:if condition="{maxitems} >= 0"> | ||
| <span class="badge t3-cd-badge"> | ||
| {f:if(condition: '{maxitems} > 99', then: '+99', else: '{maxitems}')} | ||
| </span> | ||
| </f:if> | ||
| <f:render partial="PageLayout/Grid/ColumnHeader" arguments="{_all}" /> | ||
| </div> | ||
| </f:alias> | ||
| </cd:extendPartial> | ||
|
|
||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,37 @@ | ||
| @charset "UTF-8"; | ||
|
|
||
| .t3js-page-column .t3-cd-badge-container[data-maxitems="0"] .t3-page-ce .t3js-page-new-ce, | ||
| .t3js-page-column .t3-cd-badge-container[data-maxitems="0"] .t3-page-ce .t3-page-ce-dropzone { | ||
| display: none; | ||
| } | ||
|
|
||
| body[style="cursor: move;"] .t3js-page-column .t3-cd-badge-container[data-maxitems="0"] .t3-page-ce .t3js-page-new-ce, | ||
| body[style="cursor: move;"].t3js-page-column .t3-cd-badge-container[data-maxitems="0"] .t3-page-ce .t3-page-ce-dropzone { | ||
| display: block; | ||
| visibility: hidden; | ||
| } | ||
|
|
||
| .t3-cd-badge-container:not([data-maxitems="-1"]).t3-cd-badge-container-length-1 .t3-page-column-header { | ||
| padding-left: 25px; | ||
| } | ||
|
|
||
| .t3-cd-badge-container:not([data-maxitems="-1"]).t3-cd-badge-container-length-2 .t3-page-column-header { | ||
| padding-left: 30px; | ||
| } | ||
|
|
||
| .t3-cd-badge-container:not([data-maxitems="-1"]).t3-cd-badge-container-length-3 .t3-page-column-header { | ||
| padding-left: 40px; | ||
| } | ||
|
|
||
| .t3-cd-badge-container { | ||
| position: relative; | ||
| } | ||
|
|
||
| .t3-cd-badge { | ||
|
There was a problem hiding this comment. Did you tested the layout in all TYPO3 versions yet? There was a problem hiding this comment. i say it in German – "verdammt – da war noch was 😳" I keep you updated after testing |
||
| position: absolute; | ||
| z-index: 1; | ||
| left: 0; | ||
| top: 21px; | ||
| background-color: #eaeaea; | ||
| color: #000000; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| .t3-cd-badge-container .t3-cd-badge{ | ||
| background-color: #c6bebe; | ||
| left: 1rem; | ||
| top: 0; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the CSS correctly for a full column there wouldn't be any badge anymore. But one of the main purposes is to tell the editor that there is a limit and it is reached.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the Line 3-12 just removes the «new content-element» Button not the badge.
Line 8-12 is a fix, to prevent the shifting of the Drop area if the button is hidden.
The badge is always visible. We just hide it if there is no maxitems property in the backendlayout configuration.