Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Show remaining maxitems in page module #121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

IchHabRecht
Copy link
Owner

No description provided.

@IchHabRecht
Copy link
Owner Author

Resolves: #100

@IchHabRecht IchHabRecht force-pushed the feature/show-maxitems-in-pagemodule branch from 1093d95 to 807a66e Compare January 25, 2023 22:54
@IchHabRecht IchHabRecht force-pushed the feature/show-maxitems-in-pagemodule branch from f8fbc39 to cda2b26 Compare January 26, 2023 13:33
@peterkraume
Copy link

I have tested this patch in an existing TYPO3 v11 installation and discovered a little edge case (see #122).
Despite of that everything worked fine.
But in TYPO3 v11 the visual display of the badge is a little bit lost. But I'm not sure what would be the best solution to tackle that.
Screenshot_2023-01-29_13 04 50

And finally I have a wish: please add that badge also to EXT:container elements, so the editors can see how many content elements are left for a specific column in the container columns.

@IchHabRecht
Copy link
Owner Author

Hi @peterkraume,

Thank you very much for your test and feedback.

and discovered a little edge case

I need to figure out another solution to differentiate between a negative and a non-set maxitems value.

in TYPO3 v11 the visual display of the badge is a little bit lost

Every help is more than welcome. Currently the CSS works in all supported versions 10 - 12 (although it's not optimal in 10 and 11 but it's the best I could do).

please add that badge also to EXT:container elements

As this extension is not related to container, I cannot do anything here.

@riegeo
Copy link

riegeo commented Jun 30, 2023

I'm not sure if this is possible, but what if you place the tag with the icon directly next to the Title?
content_defender-01

Then it would line up directly in the same line with some CSS.

.t3-page-column-header {
    display: flex;
    flex-wrap: wrap;
    align-content: center;
    align-items: center;
}

.t3-cd-badge {
    display: inline-block;
    margin-left: 15px;
}

So the badge is inline with the Title.
content_defender-02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants