Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finance Web App - Project Completed 💯 #4

Merged
merged 60 commits into from
Aug 4, 2023
Merged

Finance Web App - Project Completed 💯 #4

merged 60 commits into from
Aug 4, 2023

Conversation

ITurres
Copy link
Owner

@ITurres ITurres commented Aug 3, 2023

Finance Web App 💱 - React + Redux Project tools

This Pull Request merges the "development" branch into the "main" branch of the Finance Web application. With this merge, users can see companies listed on the NASDAQ stock exchange and view their current stock prices. Users can also search for companies by name and view the latest information related to the stock market and the company itself.


Changes Made ✔️

  • 📋 Set up and used a Kanban board to track progress and manage workflow.
  • 🚀 Created the application using Create React App.
  • 🛣️ Developed routing with React Router.
  • 🧰 Installed and configured Redux for state management.
  • 🖥️ Created views and components for the Home page, Company Page and related children.
  • 📡 Implemented Redux actions and reducers for fetching data from the FMP WEB API.
  • 🚀 Developed reducer for filtering companies by company name.
  • 🎭 Implemented conditional component rendering to display the search bar or search icon.
  • 🧪 Added tests for all components and functions using Jest and React Testing Library.
  • 📝 Added a descriptive README file to document the application's features and functionality.

Highlights 🎯

  • 🚀 Improved the application's functionality by integrating new features and fixing bugs.
  • 📐 Followed best practices for HTML, SCSS, and JavaScript in development.
  • 📝 Documented the work in a professional and organized manner.
  • ✅ Passed all Linter tests without any errors.
  • 🗂️ Followed the correct GitFlow practices to ensure a smooth development process.
  • 🧪 Thoroughly tested all components and functionalities to ensure the application meets all requirements and functions correctly.
  • 🚀 Deployed the application to the staging environment for further testing and refinement.

Thank you for taking the time to review this PR ⭐


If you require additional information or have any questions, please feel free to contact me on Slack as Arturo (Arthur) Emanuel Guerra Iturres. I'll be happy to assist you. 🎯


@ITurres ITurres added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 3, 2023
@ITurres ITurres self-assigned this Aug 3, 2023
Copy link

@andersonlebon andersonlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ITurres

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

nodding-yes

To highlight 🍾

  • Good PR description ✔️
  • Nice use of redux to manage the store and error handling ✔️
  • Honestly this is one of the best and professioanl projects I have ever reviewed 👏 keep it up @ITurres you deserve muy follow ✔️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question @andersonlebon so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ITurres
Copy link
Owner Author

ITurres commented Aug 3, 2023

Hi Anderson! @andersonlebon, thank you so much for reviewing this PR for this project 🙏🏼 ! I am really thrilled you liked it and that you enjoyed reviewing it 😃! I wish you a good week and happy coding!

@andersonlebon
Copy link

Thannks @ITurres I wish you the same 😄

@ITurres ITurres merged commit 7a17b45 into main Aug 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants