-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finance Web App - Project Completed 💯 #4
Conversation
…on file on 'db/' -folder-
… at 'filterCompaniesData'
Feature/final touches and tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ITurres
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
To highlight 🍾
- Good PR description ✔️
- Nice use of redux to manage the store and error handling ✔️
- Honestly this is one of the best and professioanl projects I have ever reviewed 👏 keep it up @ITurres you deserve muy follow ✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question @andersonlebon
so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi Anderson! @andersonlebon, thank you so much for reviewing this PR for this project 🙏🏼 ! I am really thrilled you liked it and that you enjoyed reviewing it 😃! I wish you a good week and happy coding! |
Thannks @ITurres I wish you the same 😄 |
Finance Web App 💱 - React + Redux Project
This Pull Request merges the "development" branch into the "main" branch of the Finance Web application. With this merge, users can see companies listed on the NASDAQ stock exchange and view their current stock prices. Users can also search for companies by name and view the latest information related to the stock market and the company itself.
Changes Made ✔️
Highlights 🎯
Thank you for taking the time to review this PR ⭐
If you require additional information or have any questions, please feel free to contact me on Slack as Arturo (Arthur) Emanuel Guerra Iturres. I'll be happy to assist you. 🎯