Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDTensors] Use TensorOperations.jl v5 in tests #1483

Merged

Conversation

kmp5VT
Copy link
Collaborator

@kmp5VT kmp5VT commented Jun 4, 2024

Description

TensorOperations.jl just updated their code to work with cuTENSOR 2.0. The package is not yet registered but it is possible to use the latest version if we add the TensorOperations git repo. This PR is in response to #1476

@kmp5VT kmp5VT requested a review from mtfishman June 4, 2024 16:45
@mtfishman
Copy link
Member

Thanks, I think it is better to wait for the new version to get registered so we can let the package manager install it automatically but this is a good starting point so we're ready for when it is registered.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.05%. Comparing base (e08e131) to head (527f38e).
Report is 16 commits behind head on main.

Current head 527f38e differs from pull request most recent head 2045adc

Please upload reports for the commit 2045adc to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1483       +/-   ##
===========================================
+ Coverage   43.65%   78.05%   +34.40%     
===========================================
  Files         136      148       +12     
  Lines        8806     9679      +873     
===========================================
+ Hits         3844     7555     +3711     
+ Misses       4962     2124     -2838     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmp5VT
Copy link
Collaborator Author

kmp5VT commented Jun 5, 2024

Okay then I will close this PR and wait until there is an update. Thanks!

@kmp5VT kmp5VT closed this Jun 5, 2024
@mtfishman
Copy link
Member

We could keep this PR open, but design it so that it will work once the new version of TensorOperations.jl is registered.

@mtfishman mtfishman reopened this Jun 5, 2024
@mtfishman mtfishman changed the title [NDTensors] Add newest TensorOperations.jl with cuTENSOR tests [WIP] [NDTensors] Use TensorOperations.jl v5 in tests Jun 5, 2024
@mtfishman mtfishman marked this pull request as draft June 5, 2024 12:30
@kmp5VT
Copy link
Collaborator Author

kmp5VT commented Sep 3, 2024

@mtfishman I checked recently and we should be able to update cuTENSOR and TensorOperations to get this PR merged. I will look into it today

@mtfishman mtfishman changed the title [WIP] [NDTensors] Use TensorOperations.jl v5 in tests [NDTensors] Use TensorOperations.jl v5 in tests Sep 4, 2024
@mtfishman mtfishman marked this pull request as ready for review September 4, 2024 00:24
@mtfishman mtfishman merged commit 995b6dc into ITensor:main Sep 4, 2024
15 checks passed
@mtfishman
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants