[BlockSparseArrays] Improve the design of block views #1481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues related to block views listed in #1336. The strategy here is to change the design such that calls like
@view a[Block(1, 1)]
return something likeSubArray(a, Block(1, 1))
, while before this PR it returned the block of theBlockSparseArray
directly, which causes problems when getting views of blocks that aren't stored. There are still issues to work out with that new design but they should be easy to fix.To summarize, this fixes:
a[Block(2, 2)] .= 1
ora[Block(2, 2)] .= randn(2, 2)
.@view(a[Block(1, 1)])[1:1, 1:2] = rand(1, 2)
or@views a[Block(1, 1)][1:1, 1:2] .= rand(1, 2)
.a[Block(2), Block(2)] = randn(3, 3)
(before onlya[Block(2, 2)] = randn(3, 3)
worked).a[Block(1, 1)] = randn(3, 3)
ofsize(a[Block(1, 1)]) != (3, 3)
.