[BlockSparseArrays] Generalize matrix multiplication, dual the axes in adjoint #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
changed the title
mtfishman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes block sparse matrix multiplication to more cases, such as those involving Hermitian transposed matrices and dual axes.
Additionally, axes are now dualed in
adjoint(::BlockSparseMatrix)so that the directions align in matrix multiplication operations such asa' * a.Some issues with matrix multiplications involving dual axes may require #1479 for now. (EDIT: That was merged, and various kinds of matrix multiplications involving dual axes are working and are tested in this PR.)
This fixes some issues listed in #1336.