Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus impl of RabbitMQ MetricsCollector #78

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alexcardell
Copy link

@alexcardell alexcardell commented Jan 10, 2023

Changes

  • Add a Prometheus implementation of MetricsCollector

    This only does counts without labels due to the limitations of the interface

Extra

We can add a middleware similar to the Kamon module, for labelling metrics by queue, etc. However, I think do this in a separate PR (I'm leaning towards Epimetheus for this for effectful metrics)

@alexcardell alexcardell marked this pull request as draft January 10, 2023 17:41
@alexcardell alexcardell marked this pull request as ready for review January 10, 2023 17:45
@alexcardell alexcardell changed the title Add prometheus module Add Prometheus impl of RabbitMQ MetricsCollector Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant