Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Update PROJECTS_INACTIVITY_INTERVAL env var format #6797

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 21, 2024

What do these changes do?

Adapt the PROJECTS_INACTIVITY_INTERVAL env var to be used with an interval in ISO 8601 format.

In Pydantic v1 numbers were considered seconds by default, but in Pydantic v2 they generate a WARNING.

Related issue/s

How to test

Dev-ops checklist

⚠️ See: MR 1113

@giancarloromeo giancarloromeo changed the title ♻️ Fix PROJECTS_INACTIVITY_INTERVAL env var ♻️ Update PROJECTS_INACTIVITY_INTERVAL env var format Nov 21, 2024
@giancarloromeo giancarloromeo self-assigned this Nov 21, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.53%. Comparing base (dc0c37d) to head (cfca524).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6797      +/-   ##
==========================================
- Coverage   85.92%   85.53%   -0.39%     
==========================================
  Files        1550      619     -931     
  Lines       61749    30919   -30830     
  Branches     2164      318    -1846     
==========================================
- Hits        53058    26447   -26611     
+ Misses       8362     4412    -3950     
+ Partials      329       60     -269     
Flag Coverage Δ
integrationtests 64.76% <100.00%> (+<0.01%) ⬆️
unittests 87.14% <100.00%> (+3.32%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.06% <ø> (+0.04%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.92%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.66% <100.00%> (+8.21%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc0c37d...cfca524. Read the comment docs.

@giancarloromeo giancarloromeo changed the title ♻️ Update PROJECTS_INACTIVITY_INTERVAL env var format ♻️ Update PROJECTS_INACTIVITY_INTERVAL env var format Nov 22, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Careful with the osparc-config MR!!! This is a breaking change so you need to create different branches for those deploys where these variables cannot be applied right away until this code is released there

@giancarloromeo
Copy link
Contributor Author

Thx. Careful with the osparc-config MR!!! This is a breaking change so you need to create different branches for those deploys where these variables cannot be applied right away until this code is released there

Please, read the MR's description.

The variable type is already dt.timedelta in all deployments, so it's safe to make the change in 1-shot.

.env-devel Show resolved Hide resolved
@giancarloromeo giancarloromeo enabled auto-merge (squash) November 26, 2024 11:28
Copy link

sonarcloud bot commented Nov 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uniform the timedelta format in ENV vars
4 participants