-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️♻️ Fixes openapi specs generators and drops openapi-core
dependencies
#6787
⬆️♻️ Fixes openapi specs generators and drops openapi-core
dependencies
#6787
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6787 +/- ##
==========================================
- Coverage 88.42% 88.39% -0.04%
==========================================
Files 1545 1545
Lines 61627 61619 -8
Branches 2157 2164 +7
==========================================
- Hits 54495 54466 -29
- Misses 6803 6824 +21
Partials 329 329
Continue to review full report in Codecov by Sentry.
|
56512a2
to
8010bf9
Compare
openapi-core
dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find some questions below
packages/models-library/src/models_library/api_schemas_directorv2/clusters.py
Show resolved
Hide resolved
openapi-core
dependenciesopenapi-core
dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, as this looks quite complex, I would like to have a direct discussion about it. thanks!
3968415
to
e54cb62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good
Quality Gate passedIssues Measures |
What do these changes do?
This PR addresses the following updates and improvements missing from the migration to pydantic v2
web-api
andstorage-api
: After pydantic v2 migration there were some issues with the generator. The generator also now produces OpenAPI 3.1 specifications forapi/specs
.openapi-core
dependency: which does not support OpenAPI 3.1app.routes
with the OpenAPI document inaiohttp
applications by introducing shared fixtures inpytest_simcore.openapi_specs.py
.make services.ignore.md
behavior: The generated.md
file is no longer version-controlled, following the suggestion by @bisgaard-itis.Related issue/s
How to test
Now we can generate OAS
Dev-ops
None