Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Frontend] Trash bin #6590

Open
wants to merge 100 commits into
base: master
Choose a base branch
from

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 24, 2024

What do these changes do?

This PR implements the frontend part of the Trash bin.

Trash

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 24, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] Trash bin ✨ [Frontend] Recycle bin Oct 24, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] Recycle bin ✨ [Frontend] Trash bin Oct 24, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Oct 24, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 24, 2024
Copy link

sonarcloud bot commented Nov 26, 2024

@odeimaiz odeimaiz marked this pull request as ready for review November 26, 2024 12:40
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsaq007
Copy link
Contributor

jsaq007 commented Nov 26, 2024

Very nice. Perhaps we could indicate if there is something in the bin or not. Either with the icon changing or a count of the number of item there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants