Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper to create a new figure/axes in a qt-safe way #91

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Conversation

Tom-Willemsen
Copy link
Contributor

@Tom-Willemsen Tom-Willemsen commented Nov 30, 2024

Fixes #92

Calling plt.subplots directly in a plan breaks, if the matplotlib backend is qt (e.g. if running a plan in a standalone shell).

That's because it would try to interact with the Qt gui from the RunEngine's plan worker thread, which is invalid. Instead we need to force it to go through bluesky's matplotlib-qt integration infrastructure.

To review:

  • Run manual dae_scan plan in IBEX
  • Run manual dae_scan plan in a standalone window (this doesn't currently work on main)
  • Both cases above should run and display plots
  • Docs are clear enough

@Tom-Willemsen Tom-Willemsen marked this pull request as draft November 30, 2024 10:24
@Tom-Willemsen Tom-Willemsen marked this pull request as ready for review December 2, 2024 06:43
rerpha
rerpha previously approved these changes Dec 2, 2024
@rerpha rerpha merged commit 9e2ea16 into main Dec 2, 2024
15 checks passed
@rerpha rerpha deleted the qt_create_axes branch December 2, 2024 11:08
@rerpha rerpha restored the qt_create_axes branch December 2, 2024 11:08
@rerpha rerpha deleted the qt_create_axes branch December 2, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dae_scan manual system test broken in standalone shell
2 participants