-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging #51
Merged
Merged
Add logging #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Willemsen
force-pushed
the
add_logging
branch
3 times, most recently
from
November 6, 2024 22:44
08a87c6
to
8d692f2
Compare
And refactor existing logging code to be more standard
Tom-Willemsen
force-pushed
the
add_logging
branch
from
November 6, 2024 22:47
8d692f2
to
a3c23ee
Compare
Chsudeepta
previously approved these changes
Nov 12, 2024
I have completed the review however merging is blocked as the last push was done by me. It now requires a different reviewer to complete the merging business |
rerpha
reviewed
Nov 12, 2024
|
||
__all__ = ["setup_logging", "set_bluesky_log_levels", "file_handler"] | ||
|
||
DEFAULT_LOG_FOLDER = os.path.join("C:\\", "instrument", "var", "logs", "bluesky") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: could use a Pathlib Path()
here
Co-authored-by: Jack Harper <[email protected]>
Chsudeepta
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
To review:
logging.getLogger("foo").warn("hello")
in pydev console, check that doesn't end up in the bluesky log.ibex_bluesky_core
needs to be released after merging this so that system tests pick up the changes.