Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 23 configure bluesky logging #40

Merged
merged 18 commits into from
Oct 28, 2024

Conversation

Chsudeepta
Copy link
Contributor

@Chsudeepta Chsudeepta commented Oct 16, 2024

Added blue sky logger, unit tests, logging configuration and documentation.
This is for the ticket

@Chsudeepta Chsudeepta mentioned this pull request Oct 17, 2024
5 tasks
Copy link
Contributor

@jackbdoughty jackbdoughty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment I left regarding docs looks good to me

`logger.blueskylogger.warning("Message to be logged")`
The logger utilizes a `TimedRotatingFileHandler` defined in the `logging.conf` file that rolls over the log at midnight.

The default logging level is defined at `INFO`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking a bit here sorry- I think we should provide some more info on how to change the log level as this is one of the acceptance criteria. e.g Where do I find info on what different log levels there are? And where do I make this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logging levels are sort of python standard - DEBUG, INFO, WARNING etc. And we invoke them as --> mylogger.warning("message"), mylogger.error("another message"). I think it might be overkill to describe the python standard logging levels and calls here.
As described here, the log handler is defined in logging.conf and that's where the default logging level is set to INFO for the handler

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay cheers thats all fine then, merging now

@jackbdoughty jackbdoughty merged commit e031857 into main Oct 28, 2024
11 checks passed
@jackbdoughty jackbdoughty deleted the Ticket_23_Configure_Bluesky_Logging branch October 28, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants