Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic block signals #13

Merged
merged 24 commits into from
Aug 20, 2024
Merged

Add basic block signals #13

merged 24 commits into from
Aug 20, 2024

Conversation

Tom-Willemsen
Copy link
Contributor

@Tom-Willemsen Tom-Willemsen commented Aug 10, 2024 •
edited
Loading

#10

@Tom-Willemsen
Improve naming
863db7b 
Also make pyright a bit stricter to catch some mistakes I made
@Tom-Willemsen
Add user-facing documentation
768c935
@Tom-Willemsen Tom-Willemsen marked this pull request as ready for review August 12, 2024 19:20
jackbdoughty
jackbdoughty previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@jackbdoughty jackbdoughty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me other than one comment I made on the readme :)

doc/blocks.md Show resolved Hide resolved
@jackbdoughty jackbdoughty merged commit f1e6453 into main Aug 20, 2024
9 checks passed
@jackbdoughty jackbdoughty deleted the 10_add_block_signals branch August 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackbdoughty jackbdoughty jackbdoughty approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tom-Willemsen @jackbdoughty