Skip to content

Commit

Permalink
Update based on review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
LowriJenkins committed Aug 2, 2024
1 parent a0ddfe9 commit a955274
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Linter
name: Lint-and-test
on: [pull_request, workflow_call]
jobs:
call-workflow:
call-linter-workflow:
uses: ISISComputingGroup/reusable-workflows/.github/workflows/linters.yml@respect_existing_ruff_tomls
with:
compare-branch: origin/main
Expand All @@ -24,7 +24,7 @@ jobs:
if: ${{ always() }}
runs-on: ubuntu-latest
name: Final Results
needs: [call-workflow, tests]
needs: [call-linter-workflow, tests]
steps:
- run: exit 1
# see https://stackoverflow.com/a/67532120/4907315
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ jobs:
lint-and-test:
if: github.ref_type == 'tag'
name: Run linter and tests
uses: ./.github/workflows/Linter.yml
uses: ./.github/workflows/Lint-and-test.yml
build:
needs: lint-and-test
if: github.ref_type == 'tag'
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ pyright

### Release Process

Releases are created automatically via a github action, to create a release just create a new git tag on the commit on main (i.e. `git pull`, `git checkout main` `git tag <release.version.number.` `git push origin tag <release.version.number.`) This will start a workflow that will check that all linters and tests pass, and then publish a new release with the version number specified in the tag to [Pypi](https://pypi.org/project/ibex-bluesky-core/0.0.1/) and github. The new release can then be installed via `pip install ibex_bluesky_core`. The workflow must be approved by someone in the ICP-Write group.
Releases are created automatically via a github action, to create a release just create a new git tag on the commit on main (i.e. `git pull`, `git checkout main` `git tag <release.version.number.` `git push origin tag <release.version.number.`) This will start a workflow that will check that all linters and tests pass, and then publish a new release with the version number specified in the tag to [Pypi](https://pypi.org/project/ibex-bluesky-core/0.0.1/) and github. The new release can then be installed via `pip install ibex_bluesky_core`. The workflow must be approved by someone in the ICP-Write group. To do this go to the action (Actions -> the action on the tag) and approve it.

Credentials for Pypi can be found on keeper.

0 comments on commit a955274

Please sign in to comment.