Add CSM - Central Saint Martins - Update facilities.json #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opt IN - only City/country for address.
palemieux
approved these changes
Nov 25, 2024
src/main/data/facilities.json
Outdated
| { | ||
| "code": "CSM", | ||
| "contact": { | ||
| "address": "London, United Kingdom", |
There was a problem hiding this comment.
Suggested change
| "address": "London, United Kingdom", |
Let's remove the incomplete address.
There was a problem hiding this comment.
I think it should remain. I think it gives the region of interest to folks. Granted it's not the mailing address I think there is value to City/State.
There was a problem hiding this comment.
It breaks automation that assumes that a complete mailing address is present. The submitter should submit a complete address.
There was a problem hiding this comment.
I have added a full address...
Added an address...
palemieux
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opt IN - only City/country for address.