Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate config changes #552

Open
wants to merge 3 commits into
base: issue-511
Choose a base branch
from

Commits on Mar 14, 2024

  1. Configuration menu
    Copy the full SHA
    533b6ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3d3e036 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. no_config added everywhere and tests fixed

    Found a possible issue during testing. Some rules had lines like result = result and func(). This essentially makes it to where the func() won't run after 1 error or warning is found. This eliminates some from being repeated multiple times, but also hides when there are multiple different ones at the same time.  "test_b_ii_s_3" in isatab/validate/test_core.py is a good example. There are 2 different columns with warnings, but before this change you only saw 1 of those warnings, but those 2 warnings are repeated for each row.
    ptth222 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    52c376f View commit details
    Browse the repository at this point in the history