Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace UI with ltindalls version #1192

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Replace UI with ltindalls version #1192

merged 1 commit into from
Mar 8, 2024

Conversation

anarkiwi
Copy link
Member

@anarkiwi anarkiwi commented Mar 8, 2024

No description provided.

Copy link

github-actions bot commented Mar 8, 2024

Validation Issues Found (Python) 🐍

File: gamutrfwaterfall/gamutrfwaterfall/templates/base.html
Line Number: 7
Statement(s):

	<script src="{{ url_for('static',filename='jquery.min.js') }}"></script> 

Rule:
Detected a template variable used in a script tag. Although template variables are HTML escaped, HTML escaping does not always prevent cross-site scripting (XSS) attacks when used directly in JavaScript. If you need this data on the rendered page, consider placing it in the HTML portion (outside of a script tag). Alternatively, use a JavaScript-specific encoder, such as the one available in OWASP ESAPI. For Django, you may also consider using the 'json_script' template tag and retrieving the data in your script by using the element ID (e.g., document.getElementById).

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 20.31250% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 74.84%. Comparing base (deb9eb5) to head (0bba5be).
Report is 1 commits behind head on main.

❗ Current head 0bba5be differs from pull request most recent head 81fcc5b. Consider uploading reports for the commit 81fcc5b to get more accurate results

Files Patch % Lines
gamutrfwaterfall/gamutrfwaterfall/waterfall.py 20.31% 51 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1192      +/-   ##
==========================================
- Coverage   75.64%   74.84%   -0.81%     
==========================================
  Files          39       39              
  Lines        3737     3789      +52     
==========================================
+ Hits         2827     2836       +9     
- Misses        910      953      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anarkiwi anarkiwi merged commit 3e01bec into IQTLabs:main Mar 8, 2024
11 checks passed
@anarkiwi anarkiwi deleted the ui2 branch March 8, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant