Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File handling for gamutrf-offline #1035

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

lk-iqt
Copy link
Contributor

@lk-iqt lk-iqt commented Dec 12, 2023

Bug: cannot process recordings in current directory.
Defaults to "." if no out_dir found.

Bug: data_filename does not contain file extension. Per sigmf format - datafiles must end with .sigmf-data

https://github.com/sigmf/SigMF/blob/sigmf-v1.x/sigmf-spec.md#sigmf-file-types
Rules for SigMF Dataset files:
The Dataset file MUST have a .sigmf-data filename extension.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0b35ebf) 76.44% compared to head (a1b70ad) 76.32%.
Report is 5 commits behind head on main.

Files Patch % Lines
gamutrf/sample_reader.py 0.00% 4 Missing ⚠️
gamutrf/offline.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   76.44%   76.32%   -0.13%     
==========================================
  Files          43       43              
  Lines        3630     3636       +6     
==========================================
  Hits         2775     2775              
- Misses        855      861       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anarkiwi anarkiwi merged commit 628ac5b into IQTLabs:main Dec 12, 2023
10 of 12 checks passed
@lk-iqt lk-iqt deleted the dev-offline branch December 15, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants