Debug auto orienter #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 25, 2023 18:20
Resolve a myriad of resulting issues, including typingd, sigh.
…to-focus-option Merge leading branch of ralatsdc/edgetech-axis-ptz-controller into leading branch of IQTLabs/edgetech-axis-ptz-controller to: - Use BaseMQTTPubSub.generate_payload_json() throughout - Handle loss of camera connection gracefully Also clean up by: - Grouping arguments - Allowing configuration and logging of all inputs - Restore AxisPtzController.make_controller() since used during development, testing, and operation - Retain axis_ptz_utilities.encode_image() and axis_ptz_utilities.decode_image() since original design prohibitied passing data through files and these methods may be needed in the future
…-axis-ptz-controller into rl/debug-auto-orienter
robotastic
reviewed
Mar 13, 2024
added 4 commits
March 14, 2024 10:19
|
Looks good enough - Question on setting Yaw, Pitch, Roll via the MQTT config message. It looks like it was removed and there is this comment: Is there still a way to manually set the Yaw Pitch Roll via MQTT? It is helpful to have a way to do some live manual adjustment. Is this still possible? |
|
The orientation message sets yaw, pitch, and roll. The side effect is computing the coordinate transformations, which the orientation message callback already does.
…On Mar 15, 2024 at 8:41 AM -0400, Luke Berndt ***@***.***>, wrote:
Looks good enough - Question on setting Yaw, Pitch, Roll via the MQTT config message. It looks like it was removed and there is this comment:
Cannot set tripod yaw, pitch, and roll because of side effects
What is the side effect?
Is there still a way to manually set the Yaw Pitch Roll via MQTT? It is helpful to have a way to do some live manual adjustment. Is this still possible?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.