-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override vue MDI icons #34
Conversation
d4439de
to
c87b727
Compare
The folder icon in the file list is a bit shifted due to a |
43f635e
to
85e23b2
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
I had a 2nd quick look at it, looked good to me. |
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
2fc82e4
to
0ce8b2c
Compare
font awesome folder icon is smaller then MDI icon Signed-off-by: Misha M.-Kupriyanov <[email protected]> Co-authored-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]> ci(make): add build_vue_icons_package job in order to be able to build with custom vue icons Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Tatjana Kaschperko Lindt <[email protected]>
aa1f044
to
e25341c
Compare
Summary
inspect locally with
./<nc-docs-and-tools>/container/check_release.sh pr-34
TODO
Checklist