Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override vue MDI icons #34

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Override vue MDI icons #34

merged 5 commits into from
Sep 30, 2024

Conversation

printminion-co
Copy link

@printminion-co printminion-co commented Sep 10, 2024

Summary

  • replace MDI vue iconst package with custom one
  • rebuild nc-server frontend

inspect locally with ./<nc-docs-and-tools>/container/check_release.sh pr-34

TODO

  • ...

Checklist

.gitmodules Outdated Show resolved Hide resolved
@thlehmann-ionos
Copy link

The folder icon in the file list is a bit shifted due to a margin: -3px on a span with .folder-icon.

@printminion-co printminion-co force-pushed the mk/feat/override_vue_mdl_icons branch 5 times, most recently from 43f635e to 85e23b2 Compare September 20, 2024 14:40
@printminion-co
Copy link
Author

The folder icon in the file list is a bit shifted due to a margin: -3px on a span with .folder-icon.

cant confirm it...
image

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@thlehmann-ionos
Copy link

I had a 2nd quick look at it, looked good to me.

@tanyaka tanyaka force-pushed the mk/feat/override_vue_mdl_icons branch from 2fc82e4 to 0ce8b2c Compare September 27, 2024 13:04
printminion-co and others added 4 commits September 30, 2024 12:33
font awesome folder icon is smaller then MDI icon

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Co-authored-by: Tatjana Kaschperko Lindt <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
ci(make): add build_vue_icons_package job

in order to be able to build with custom vue icons

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
@tanyaka tanyaka force-pushed the mk/feat/override_vue_mdl_icons branch from aa1f044 to e25341c Compare September 30, 2024 10:52
@tanyaka tanyaka merged commit e038432 into ionos-dev Sep 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants