Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete share confirmation (stable29) #27

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

printminion-co
Copy link

@printminion-co printminion-co commented Aug 2, 2024

Added confirmation dialog analogue to file (>5 files) deletion.

Checklist

@printminion-co printminion-co force-pushed the mk/dev/delete_share_confirmation branch from adff217 to a433790 Compare August 5, 2024 09:20
Copy link

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to make this upstreamable
Also please make sure to add yourself to the license header and ensure the compilation works properly

apps/files_sharing/src/mixins/SharesMixin.js Outdated Show resolved Hide resolved
apps/files_sharing/src/mixins/SharesMixin.js Outdated Show resolved Hide resolved
@printminion-co printminion-co force-pushed the mk/dev/delete_share_confirmation branch from 1497461 to 5dba5f0 Compare August 6, 2024 09:19
@printminion-co
Copy link
Author

changed text in order to be similar to "delete files" confirmation dialog
Selection_20240806-001

@printminion-co printminion-co changed the title delete share confirmation delete share confirmation (stable29) Aug 6, 2024
Copy link

@thlehmann-ionos thlehmann-ionos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly OK for me, a couple of minor notes though.

  • Looks good to me (cancel does not delete, confirm deletes) 💚
  • Unit tests OK ✔️
  • Linter OK ✔️
  • Code style OK if one review note is addressed (semi-colon) ✔️
  • Cypress tests don't seem to test or use this: OK ✔️
  1. I'd like to see the semi-colon removed, the superfluous parens removed and the async/await vs. Promise mixture changed
  2. I'm undecided on the action button type and leave it up to you since there's no clear guide (you may want to mention this when upstreaming this as a PR)

apps/files_sharing/src/mixins/SharesMixin.js Show resolved Hide resolved
apps/files_sharing/src/mixins/SharesMixin.js Outdated Show resolved Hide resolved
apps/files_sharing/src/mixins/SharesMixin.js Outdated Show resolved Hide resolved
apps/files_sharing/src/mixins/SharesMixin.js Outdated Show resolved Hide resolved
@printminion-co printminion-co force-pushed the mk/dev/delete_share_confirmation branch from 5dba5f0 to 14d3df0 Compare August 7, 2024 12:12
@printminion-co printminion-co force-pushed the mk/dev/delete_share_confirmation branch from 14d3df0 to 66f37ed Compare August 7, 2024 13:41
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
@printminion-co printminion-co merged commit 153f216 into ionos-dev Aug 7, 2024
3 of 4 checks passed
@printminion-co printminion-co deleted the mk/dev/delete_share_confirmation branch August 7, 2024 14:16
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants