-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete share confirmation (stable29) #27
Conversation
adff217
to
a433790
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try to make this upstreamable
Also please make sure to add yourself to the license header and ensure the compilation works properly
1497461
to
5dba5f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly OK for me, a couple of minor notes though.
- Looks good to me (cancel does not delete, confirm deletes) 💚
- Unit tests OK ✔️
- Linter OK ✔️
- Code style OK if one review note is addressed (semi-colon) ✔️
- Cypress tests don't seem to test or use this: OK ✔️
- I'd like to see the semi-colon removed, the superfluous parens removed and the async/await vs. Promise mixture changed
- I'm undecided on the action button type and leave it up to you since there's no clear guide (you may want to mention this when upstreaming this as a PR)
5dba5f0
to
14d3df0
Compare
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
14d3df0
to
66f37ed
Compare
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Added confirmation dialog analogue to file (>5 files) deletion.
Checklist