Skip to content

Commit

Permalink
[PCB Print][Fixed] Drill marks issues
Browse files Browse the repository at this point in the history
- When colored_vias/pads are disabled
- And using KiCad 8.0.4+ which likes to print them in all layers

Fixes #696
  • Loading branch information
set-soft committed Oct 17, 2024
1 parent ac51a10 commit 97309ea
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 4 deletions.
7 changes: 5 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Export Project: problems when downloading KiCad models and trying to compress
the result.
- PcbDraw: problems with 0 ohms THT resistors (#689)
- PCB Print: allow specifying `repeat_for_layer` with empty `repeat_layers`.
This was the old behavior (i.e. 1.7.0) (#671)
- PCB Print:
- Allow specifying `repeat_for_layer` with empty `repeat_layers`.
This was the old behavior (i.e. 1.7.0) (#671)
- Problems with drill marks on KiCad 8.0.4+, which prints them in every
single layer (even technical ones) (#696)
- Expansion of internal field names. KiCad expands "VALUE", not "Value", which
is what you see in the GUI

Expand Down
9 changes: 7 additions & 2 deletions docs/source/Changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,13 @@ Fixed
- Export Project: problems when downloading KiCad models and trying to
compress the result.
- PcbDraw: problems with 0 ohms THT resistors (#689)
- PCB Print: allow specifying ``repeat_for_layer`` with empty
``repeat_layers``. This was the old behavior (i.e. 1.7.0) (#671)
- PCB Print:

- Allow specifying ``repeat_for_layer`` with empty
``repeat_layers``. This was the old behavior (i.e. 1.7.0) (#671)
- Problems with drill marks on KiCad 8.0.4+, which prints them in
every single layer (even technical ones) (#696)

- Expansion of internal field names. KiCad expands “VALUE”, not
“Value”, which is what you see in the GUI

Expand Down
3 changes: 3 additions & 0 deletions kibot/out_pcb_print.py
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,7 @@ def plot_frame_api(self, pc, po, p):
po.SetPlotFrameRef(True)
po.SetScale(1.0)
po.SetNegative(False)
po.SetDrillMarksType(0)
pc.SetLayer(self.cleared_layer)
pc.OpenPlotfile('frame', PLOT_FORMAT_SVG, p.sheet)
pc.PlotLayer()
Expand Down Expand Up @@ -541,6 +542,8 @@ def plot_frame_internal(self, pc, po, p, page, pages):
po.SetPlotFrameRef(False)
po.SetScale(1.0)
po.SetNegative(False)
# We don't want drill marks in the frame
po.SetDrillMarksType(0)
# Trying to set the color mode here doesn't change the mode (GetColorMode() returns False)
# pc.SetColorMode(True)
pc.SetLayer(self.cleared_layer)
Expand Down

0 comments on commit 97309ea

Please sign in to comment.