Modification of the CLI to include the use of ElabFTW methods. #75
Conversation
The methods / options will be modified as the methods are developed
JuliaSprenger
added
the
safe to test
Removed the addition of a new parser. Now only one option added to define if we want to use the RedCap server or the ElabFTW server
Removed the addition of a new parser. Now only one option added to define if we want to use the RedCap server or the ElabFTW server
|
Yes, for the tests I have to modify them as well |
|
You should not need to modify the cli-redcap tests, but only extend them by elab related tests. |
Modification of the test function for the CLI
Modification of the test function for the CLI
Modification of the test function for the CLI
Modification of the CLI tests
|
@JuliaSprenger I have an error in the tests. Is it because I created an experiment_id argument? I think the error comes from the fact that it is expected even if I use the redcap server, no? If that's the case, I should only add this argument when I use the elabftw server, right? |
…oad experiment_id is required
…oad experiment_id is required
…labftw is provided
…labftw is provided
Adding of elabftw test download
|
@JuliaSprenger Do you see something that need to be change ? For the output, as I said, it's a first basic version, i think i'll update the CLI after merging the branch containing the download function |
| @@ -50,3 +50,10 @@ def test_download(initialize_test_dir): | |||
| stdout=subprocess.PIPE) | |||
| assert 'error' not in str(result.stdout) | |||
| assert pathlib.Path(output_file).exists() | |||
|
|
|||
| # download with Elabftw server | |||
| result = subprocess.run(['RedCapBridge', 'download', SERVER_CONFIG_YAML, '--server', 'elabftw', '232'], | |||
There was a problem hiding this comment.
Here you are assuming the content of experiment id 232 on the server. However this won't work for another elab server or when the server is cleaned or someone manually deletes that experiment. It would be better to upload a known experiment first to then test the download function on that new experiment. Ideally you would also remove that experiment again from the server afterwards to keep everything in a clean state.
|
Hi @killianrochet With the big refactoring recently this PR is a bit outdated and some of the issues you address here can be solved in a more elegant way now using the new elab server functionalities. Could you bring the changes up to date? Looking at the few lines that have been changed here and it might be the easiest to start a new branch from the current master instead of rebasing / merge this outdated branch... |
Hello @JuliaSprenger ,
I started to modify the CLI, trying to follow the same method as for redcap. I'd like some feedback on the start of the modifications.
Thank you!
The methods / options will be modified as the methods are developed