Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update autoconvert option #139

Merged
merged 10 commits into from
Nov 29, 2022
Merged

Update autoconvert option #139

merged 10 commits into from
Nov 29, 2022

Conversation

JuliaSprenger
Copy link
Collaborator

solves #136 and moves the autoconvert option from register_data_files to organize_data_files

@coveralls
Copy link

coveralls commented Oct 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3440609416

  • 74 of 77 (96.1%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 75.726%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bep032tools/generator/BEP032Generator.py 23 26 88.46%
Totals Coverage Status
Change from base Build 3440291167: 0.7%
Covered Lines: 1095
Relevant Lines: 1446
💛 - Coveralls

@SylvainTakerkart SylvainTakerkart self-requested a review November 7, 2022 16:00
@JuliaSprenger
Copy link
Collaborator Author

Tests are succeeding on ubuntu, but installation of git fails on windows. This is not related to the changes in this PR, so we can merge this PR and fix the tests in a separate PR.

@JuliaSprenger JuliaSprenger marked this pull request as ready for review November 9, 2022 09:47
SylvainTakerkart
SylvainTakerkart approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@SylvainTakerkart SylvainTakerkart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SylvainTakerkart
Copy link
Collaborator

let's move forward and try this ;)

@SylvainTakerkart SylvainTakerkart merged commit eb580f0 into INT-NIT:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvainTakerkart SylvainTakerkart SylvainTakerkart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuliaSprenger @coveralls @SylvainTakerkart