Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update h1-6 and top tag to @font-header #157

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Update h1-6 and top tag to @font-header #157

merged 1 commit into from
Feb 11, 2020

Conversation

joshdarby
Copy link

@joshdarby joshdarby commented Feb 11, 2020

Changes

This pull request makes the following changes:

  • Updates h1-h6 and .top-tag to use font-header instead of font-body

Before (ignore missing images):
screencapture-citylimits-test-2020-02-11-09_40_28

After (ignore missing images):
screencapture-citylimits-test-2020-02-11-09_39_36

Why

For #154

Testing/Questions

Features that this PR affects:

  • Font used for headings and top tags

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • Do we need to update the font for any other type of element?
  • Should we also update the tt-plain and tt-fancy mixins?
    .tt-plain {
    border: 1px solid @red;
    width: auto;
    display: inline-block;
    clear: both;
    &::after {
    display: table;
    content: "";
    clear: both;
    }
    }
    .tt-fancy {
    margin-left: auto;
    margin-right: auto;
    clear: both;
    max-width: calc( 100% - (2 * @measure ) );
    //width: min-content;
    width: auto;
    text-align: center;
    border-width: @measure * 0.5;
    border-color: @white;
    border-style: solid;
    border-image: url("/wp-content/themes/citylimits/img/top-term-border-image.png"); // absolute URL because this is a mixin that may be called from the homepage stylesheet.
    border-image-slice: 24 24 24 24;
    border-image-repeat: space;
    }

Steps to test this PR:

  1. View the site and make sure no fonts are wrong or missing

@joshdarby joshdarby self-assigned this Feb 11, 2020
@joshdarby joshdarby merged commit ee16cd5 into master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants