Tests #35
Merged
Tests #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhnnsnk ; this can be merged. Shouldn't break anything; but the github action will complain a bit if pushed code doesn't conform to flake8 standards (less stringent than the other PEP8 PR). |
jhnnsnk
reviewed
Dec 11, 2020
|
|
||
| """ | ||
|
|
||
| import unittest |
There was a problem hiding this comment.
We recently used pytest in a different project (https://github.com/INM-6/lif_meanfield_tools) and I really liked it. Are there any specific reasons for using unittest here?
There was a problem hiding this comment.
None other than that unittest is part of the standard library and pytest is not. But I install it anyway to run the tests so please go ahead and use the latter if you want in the future.
There was a problem hiding this comment.
I think unittest is ok here. I will merge.
Co-authored-by: Johanna Senk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should get #16 started by running test suite in /mesocircuit/tests/ automatically as well as some flake8 linting (#9).