Port delay re-draw fix #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
otcathatsya
commented
Apr 10, 2024
•
otcathatsya
commented
- Reference for delay change: The cortical microcircuit NEST examples do not generate the number of connections with a minimal delay that one might expect nest/nest-simulator#2503
- This was fixed in the NEST-local example a while back but seemingly not updated elsewhere
- Note: This was also applied to MAM now and also needs to be re-re-ported to NEST master
otcathatsya
changed the title
otcathatsya
changed the title
otcathatsya
force-pushed
the
port_delay_fix
branch
from
913ccd6
to
f3c7a46
Compare
mlober
requested changes
Jun 19, 2024
| @@ -671,7 +672,7 @@ def connect(simulation, | |||
| mean=mean_delay, | |||
| std=mean_delay * network.params['delay_params']['delay_rel'] | |||
| ), | |||
| min=simulation.params['dt'], | |||
| min=dt - 0.5 * dt, | |||
There was a problem hiding this comment.
This only works if dt=nest.resolution. Subtract nest.resolution instead of dt.
mlober
approved these changes
Jun 20, 2024
ackurth
reviewed
Jun 21, 2024
ackurth
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.