Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BUILDER_CONFIG environment variable #66

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

terhorstd
Copy link
Collaborator

To make the configuration file select-able from the environment, this PR adds the BUILDER_CONFIG variable. For existing setups nothing should change, as the default value remains the same. It however enables users to keep different Builder configurations around (or in a repository) and point Builder to the one to use.

fixes #65

Copy link

@finnerty-fzj finnerty-fzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.buildrc is also mentioned in Install.md and README.md without editing. Would suggest at least mention of possibility of using an alternative file in mentioned in the README.md.

Merge request also has minor unrelated changes, is this ok with project policy?

plans/nest-simulator/3.1/default Show resolved Hide resolved
plans/nest-simulator/common Show resolved Hide resolved
plans/nest-simulator/master/default Show resolved Hide resolved
doc/Configuration.md Show resolved Hide resolved
Copy link

@finnerty-fzj finnerty-fzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more to say.

@terhorstd
Copy link
Collaborator Author

Thanks for the quick review!

@terhorstd terhorstd merged commit 74dc68f into INM-6:master Sep 6, 2023
2 checks passed
@terhorstd terhorstd deleted the add_buildrc_var branch September 6, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use alternative buildrc file as option
2 participants