Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ${VARIANT} to module load log message #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ${VARIANT} to module load log message #58

wants to merge 2 commits into from

Conversation

akorgor
Copy link
Contributor

@akorgor akorgor commented Jun 13, 2022

No description provided.

terhorstd
terhorstd reviewed Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually required? For me the modules load without giving a variant. Maybe this is also a difference between the TCL and LMOD systems. On which one did you try this?

@akorgor
Copy link
Contributor Author

akorgor commented Dec 5, 2022

Could be related to this issue. Tried it on JURECA-DC, which has LMOD.

terhorstd
terhorstd reviewed Jan 12, 2023
View reviewed changes
build_functions.sh Outdated Show resolved Hide resolved
terhorstd
terhorstd requested changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure about this one, but since it's a so tiny change and it doesn't break anything I'm inclined to just put it in. I also didn't come across more lmod-vs-tcl things recently.

build_functions.sh Outdated Show resolved Hide resolved
@akorgor
Copy link
Contributor Author

akorgor commented Jan 16, 2023

Giving both would be indeed a good solution.

@akorgor @terhorstd
Update build_functions.sh
ab0e180 
Co-authored-by: Dennis Terhorst <[email protected]>
@akorgor akorgor requested a review from terhorstd January 17, 2023 11:00
terhorstd
terhorstd approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This should be fine for now. Still fighting myself to understand the full implications of the version/variant syntax in LMOD, but that shouldn't stop us here.

@akorgor
Copy link
Contributor Author

akorgor commented Sep 6, 2024

@terhorstd Should I merge or close this old PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terhorstd terhorstd terhorstd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akorgor @terhorstd