Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yaml to use canonical form for true/false in tests dir #930

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Update yaml to use canonical form for true/false in tests dir #930

merged 2 commits into from
Oct 2, 2023

Conversation

anitacaron
Copy link
Contributor

Fixes #674

@anitacaron anitacaron self-assigned this Sep 26, 2023
@anitacaron anitacaron modified the milestone: 1.5 Sep 27, 2023
matentzn
matentzn approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @gouttegd cant think of a reason this is problematic - I cant!

gouttegd
gouttegd approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won’t start ranting about how JSON/YAML are insane for accepting so many values as booleans in the first place. Happy to see that YAML 1.2 at least has a bit more sense.

@anitacaron anitacaron merged commit ca68333 into master Oct 2, 2023
1 check passed
@anitacaron anitacaron deleted the anitacaron/issue674 branch February 29, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouttegd gouttegd gouttegd approved these changes

@matentzn matentzn matentzn approved these changes

Assignees

@anitacaron anitacaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add warning to next release to use canonical form for booleans in config files
3 participants
@anitacaron @matentzn @gouttegd