-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to include defined-by annotation in imports #929
Conversation
Should this be user-configurable? Ticket #796 says “we should consider adding this by default to ODK” (emphasis mine), which suggests users should have the possibility of disabling it. |
Can you clarify, @matentzn, please? |
This should be configurable at least on import_group level, because the file size will blow up massively with that feature, and we want to at least give some hope that it can be switched off for people for which size matters (github file size limits etc). Also, what about the case that you are not using base merging, but want to use this feature when creating the full.owl release? Isnt this another case where we may want this (we could use the same flag from import_group.annotate_defined_by)? |
Ok, I'll add the configuration for this. |
@matentzn is ready for review again |
From now on for changes that affect the pipeline, we should have two independent reviews. To minimise mistakes.. |
Fixes #796
There're two cases:
use_base_merging: true
, the option is added when merging all mirrors, so then we can get properly where the terms come from.use_base_merging
not defined, the option is added during the release process.