Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to include defined-by annotation in imports #929

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

anitacaron
Copy link
Contributor

Fixes #796

There're two cases:

  1. When use_base_merging: true, the option is added when merging all mirrors, so then we can get properly where the terms come from.
  2. When use_base_merging not defined, the option is added during the release process.

@anitacaron anitacaron self-assigned this Sep 26, 2023
@gouttegd
Copy link
Contributor

Should this be user-configurable? Ticket #796 says “we should consider adding this by default to ODK” (emphasis mine), which suggests users should have the possibility of disabling it.

@anitacaron
Copy link
Contributor Author

Can you clarify, @matentzn, please?

@matentzn
Copy link
Contributor

This should be configurable at least on import_group level, because the file size will blow up massively with that feature, and we want to at least give some hope that it can be switched off for people for which size matters (github file size limits etc).

Also, what about the case that you are not using base merging, but want to use this feature when creating the full.owl release? Isnt this another case where we may want this (we could use the same flag from import_group.annotate_defined_by)?

@anitacaron
Copy link
Contributor Author

Ok, I'll add the configuration for this.

@anitacaron
Copy link
Contributor Author

@matentzn is ready for review again

@matentzn
Copy link
Contributor

From now on for changes that affect the pipeline, we should have two independent reviews. To minimise mistakes..

@anitacaron anitacaron merged commit b7cd431 into master Nov 6, 2023
1 check passed
@anitacaron anitacaron deleted the anitacaron/issue796 branch February 29, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rdfs:isDefinedBy to imports
3 participants