Run under root by default unless ODK_USER_ID is explicitly set. #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the entry point script so that it defaults to run the inner processes as root, unless the ODK_USER_ID variable is explicitly set to something else than zero. This avoids breaking things for users who for some reasons do not pass the `ODK_USER_ID` variable when they invoke the ODK -- which includes Windows users, since the `run.bat` script has never been updated to pass that variable.
matentzn
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the entry point script so that it defaults to run the inner processes as root, unless the
ODK_USER_IDvariable is explicitly set to something else than zero.This avoids breaking things for users who for some reasons do not pass the
ODK_USER_IDvariable when they invoke the ODK – which includes Windows users, since therun.batscript has never been updated to pass that variable.