Write $(SRCMERGED) in OFN format. #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the $(SRCMERGED) intermediate file is always written in OFN format, rather than in the same format than the -edit file. If $(SRCMERGED) is written in OBO format, this can cause some checks made on that file to fail because of some peculiarities of the OBO serialisation that do not accurately reflect the contents of the original -edit file. closes #1107
|
@matentzn Not going to merge this one without your input on it, even if it has to wait. |
matentzn
reviewed
Oct 18, 2024
matentzn
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the
$(SRCMERGED)intermediate file is always written in OFN format, rather than in the same format than the -edit file.If
$(SRCMERGED)is written in OBO format, this can cause some checks made on that file to fail because of some peculiarities of the OBO serialisation that do not accurately reflect the contents of the original -edit file.closes #1107