Use mcx SLIT source for MSOTAcuity and MSOTInvision sources #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MSOTAcuityIlluminationGeometry - Change in source due to fixing of sign error - MSOTInVisionIlluminationGeometry - Change in source due to use of gaussian broadening instead of step function - Now only requires a single mcx run using the new multiple sources feature - Note: requires mcx version >= v2024.2
|
@kdreher this works for me with mcx compiled from this branch: fangq/mcx#214 |
|
@kdreher this should now work with the latest nightly build of mcx |
kdreher
requested changes
Mar 11, 2024
There was a problem hiding this comment.
The changes look good to me.
I think we'll need a couple more changes before we merge this, though:
- When I try to run the
minimal_optical_simulation.pywithSAVE_REFLECTANCEandSAVE_PHOTON_DIRECTIONasTrue, I get a shape mismatch error. I already tried the change suggested in this pull request but that didn't work. So I guess there is another issue. - We need to adjust the invision example
- We need to adjust the README.md to the new way of using mcx
…ith a 3d fluence array - shape of mc2 file depends on mcx version and this format is now deprecated in mcx
kdreher
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the following before creating the pull request (PR):
List any specific code review questions
List any special testing requirements
Requires mcx version >= v2024.2
Additional context (e.g. papers, documentation, blog posts, ...)
Provide issue / feature request fixed by this PR