Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing spacing to error message #250

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

faberno
Copy link
Collaborator

@faberno faberno commented Oct 1, 2023

Please check the following before creating the pull request (PR):

  • Did you run automatic tests?
  • Did you run manual tests?
  • Is the code provided in the PR still backwards compatible to previous SIMPA versions?

Provide issue / feature request fixed by this PR

Fixes #249

TomTomRixRix
TomTomRixRix previously approved these changes Oct 6, 2023
Copy link
Collaborator

@TomTomRixRix TomTomRixRix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Makes sense to add it to the error message as it also is in the condition itself

@TomTomRixRix
Copy link
Collaborator

wait, this PR wants to merge into main but it should be develop first. With the next release the code will be merged from develop into main. Could you please change this @faberno?

@faberno faberno changed the base branch from main to develop October 6, 2023 13:36
@faberno faberno dismissed TomTomRixRix’s stale review October 6, 2023 13:36

The base branch was changed.

@kdreher kdreher merged commit 1226692 into develop Jun 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong error message in curved_array.check_settings_prerequisites
3 participants