Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatroom: Add mysql2 #8563

Closed
wants to merge 1 commit into from
Closed

Conversation

lscharmer
Copy link
Contributor

@lscharmer lscharmer commented Nov 29, 2024

This PR adds mysql2 as NPM dependency for the chatroom.

General Information:

  • this dependency was already used in ILIAS.
  • License: MIT

Usages:

  • components/ILIAS/Chatroom/chat/Persistence/Database.js

Wrapped By:

  • Database (see: components/ILIAS/Chatroom/chat/Persistence/Database.js)

Reasoning:

This dependency is a replacement for the mysql dependency, which was not updated since 2022, as noted in the dependency PR for ILIAS 10: #6773.

mysql2 is a mysql driver for Node.js. It is used to communicate with a mysql (or mariadb) server.

Maintenance:

mysql2 is actively maintained and regularly updated (The latest release is from 28.11.2024).

Links:

@lscharmer lscharmer added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 29, 2024
@kergomard
Copy link
Contributor

We would kindly ask @lscharmer and @mjansenDatabay to see if https://www.npmjs.com/package/mariadb would be a valid solution. If possible we would prefer this solution. If not, we accept this dependency for ILIAS 11.

@mjansenDatabay
Copy link
Contributor

This PR can be closed, we proposed to add mariadb as alternative for mysql, see #8749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants