PRG: raise event 'userReAssigned'

* #8186 * https://mantis.ilias.de/view.php?id=42104
ILIAS-eLearning · Dec 6, 2024 · 6db1ce9 · 6db1ce9
1 parent 32e2593
commit 6db1ce9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 8 deletions.
diff --git a/Modules/StudyProgramme/classes/Events/class.ilStudyProgrammeEvents.php b/Modules/StudyProgramme/classes/Events/class.ilStudyProgrammeEvents.php
@@ -20,6 +20,22 @@
 
 class ilStudyProgrammeEvents implements StudyProgrammeEvents
 {
+    public const PUBLIC_EVENTS = [
+        self::EVENT_USER_ASSIGNED,
+        self::EVENT_USER_DEASSIGNED,
+        self::EVENT_USER_REASSIGNED,
+    ];
+    /*
+        self::EVENT_USER_SUCCESSFUL,
+        self::EVENT_USER_NOT_SUCCESSFUL,
+        self::EVENT_VALIDITY_CHANGE,
+        self::EVENT_SCORE_CHANGE
+
+        will all trigger self::EVENT_USER_SUCCESSFUL on ilAppEventHandler,
+        but only once! and for root-prg only.
+        This prevents e.g. certificate to rebuild on every (sucessive) change
+    */
+
     public function __construct(
         protected ilLogger $logger,
         protected ilAppEventHandler $app_event_handler,
@@ -80,20 +96,16 @@ public function raise(string $event, array $parameter): void
         if ($event === self::EVENT_USER_REASSIGNED) {
             $this->prg_event_handler->sendReAssignedMail($parameter['ass_id'], $parameter['root_prg_id']);
         }
-
-        if (in_array($event, [
-            self::EVENT_USER_ASSIGNED,
-            self::EVENT_USER_DEASSIGNED
-        ])) {
-            $this->app_event_handler->raise(self::COMPONENT, $event, $parameter);
-        }
-
         if ($event === self::EVENT_VALIDITY_CHANGE) {
             $this->prg_event_handler->resetMailFlagValidity($parameter['ass_id'], $parameter['root_prg_id']);
         }
         if ($event === self::EVENT_DEADLINE_CHANGE) {
             $this->prg_event_handler->resetMailFlagDeadline($parameter['ass_id'], $parameter['root_prg_id']);
         }
+
+        if (in_array($event, self::PUBLIC_EVENTS)) {
+            $this->app_event_handler->raise(self::COMPONENT, $event, $parameter);
+        }
     }
 
     public function userAssigned(ilPRGAssignment $assignment): void

diff --git a/Modules/StudyProgramme/module.xml b/Modules/StudyProgramme/module.xml
@@ -40,6 +40,7 @@
 
 		<event type="raise" id="userAssigned" />
 		<event type="raise" id="userDeassigned" />
+		<event type="raise" id="userReAssigned" />
 		<event type="raise" id="userSuccessful" />
 	</events>
 	<crons>