Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permalinks to pages to avoid .html extension #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peey
Copy link
Collaborator

@peey peey commented Oct 27, 2019

Closes #89

@peey
Copy link
Collaborator Author

peey commented Oct 27, 2019

@virresh seems to work. Have a look.

@virresh
Copy link
Member

virresh commented Oct 28, 2019

Actually if I look back at netlify deploys, it works regardless:
Deploy from last merged PR: https://deploy-preview-88--brave-nightingale-ea2673.netlify.com/hackathons

This is probably because netlify already uses nginx to serve pages and nginx handles url re-writes much more cleanly than latest apache version
So unless we merge it, I don't think we'll be able to test it out (or we sideload directly this branch on server rather than polluting the commit history)

@virresh
Copy link
Member

virresh commented Oct 28, 2019

(And same goes for gh-page deployment as well): https://iiit-delhi.github.io/byld-website/hackathons

@peey
Copy link
Collaborator Author

peey commented Oct 28, 2019

I'm confused about why netlify is working prior to this fix. We don't have a htaccess file committed.

Where exactly are we directing nginx/apache server to rewrite a.html to a?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants